Add PeerJS Extension #1897
Add PeerJS Extension #1897
Conversation
github-actions
bot
added
the
pr: new extension
"Links to places other than Scratch are not allowed at this time"
|
PeerJS?! Your Adding It? Yayyyyyyyyyy |
Thebloxers998
left a comment
Thebloxers998
left a comment
There was a problem hiding this comment.
This is the best extension for multiplayer, nice 👍
|
Where is the create peer block |
|
Noted requested changes, will be working on them. |
|
I'll do a review |
CubesterYT
left a comment
CubesterYT
left a comment
There was a problem hiding this comment.
Round one of reviews
This extension is VERY weird.
|
!format |
|
huh, neat |
Yeah, lol, it's a workflow I made (polished by GarboMuffin) |
|
since we're here, can someone please fix the website's credit link to point to my new account? thanks |
CubesterYT
left a comment
CubesterYT
left a comment
There was a problem hiding this comment.
Final review from what I see.
I'd recommend making documentation, so people can have a better understanding on how to use this extension, but it isn't required.
I would like for others to review as well, in case I missed anything.
|
I don't think I'm using |
it's async (so awaitable) |
* Updated title * Minified ULID function * Prettier - Removed trailing commas
|
!format |
|
😭 |
CubesterYT
left a comment
CubesterYT
left a comment
There was a problem hiding this comment.
Looks good to me, now we just wait on the others.
|
Why does the block "enableVerboseLogs" exist even though the toggle logs block exists? |
He released this extension earlier to his own people, so technically, just like your extensions, they are already being used by real people, and he rather not break compatibility. |
Ah okay. |
|
Seems all good then |
|
I realized way too late that I forgot to add a function to close channels. Oopsies. This should be a draft anyways since TW needs some sort of warning mechanism about P2P. |
|
So can someone help me understand what exactly is keeping this from being merged? |
I haven't paid much attention to this issue, but there are a few key elements that needs addressing before it's safe to merge.
|
|
Going to bump this. The repository changed ownership back to my personal account, and there have been a few bugfixes here and there. Still waiting on some sort of menu alert to warn about P2P connectivity. Edit: I am stupid and realized that bumps don't exist for PRs |
8 participants
https://github.com/cloudlink-omega/peerjs-scratch
This was intended to be an experimental foundation for a CL5 rewrite but I thought it would be perfectly fine making it it's own thing.
I'm not 100% sure if my tweaks to the original code would make it fully compliant with the "Banned APIs" section.